Skip to content

Conversation

@maurerle
Copy link
Member

Description

This feature was added in #264.
However, the calculation to only colorize sufficiently stable connections in blue was missing on the map view and only made it to the forcegraph. @skorpy2009

Motivation and Context

Links of type other with bad TQ should also show the quality.
Such links might not be wired at all (e.g. P2P wireless inbetween) and therefore should show as normal links.

Example here: https://map.aachen.freifunk.net/#/en/map/001b215925ad-a0f3c1780868

How Has This Been Tested?

Screenshots/links:

Checklist:

  • My code follows the code style of this project. (CI will test it anyway and also needs approval)
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

@Djfe
Copy link

Djfe commented Jan 26, 2026

ups, I missed this pr.
further notes/ideas related to this pr
#293

should low TQ other connections have a different color from red like purple? (gradient from light blue to purple)
this could highlight issues with wired connections better
Or is it then unclear how to prioritize wired over wireless since wireless could have a higher TQ at times?

what is link in this context? the connection with the highest TQ? there are two different TQs (source and target) per link, how is this sorted/determined?
depending on the setup download could be wired while batman sends upload traffic wireless due to TQ (unlikely setup but possible since links can be asynchronous) leading to good TQ in both directions but the map might show bad TQ sind it only considers one link(?)

yes, keeping the logic mostly simple should take priority and I am overcomplicating things a bit.

Still these are my two cents here

@maurerle
Copy link
Member Author

@Djfe looking at the single line change of this PR here: https://github.com/freifunk/meshviewer/pull/292/files shows that a link indeed has two TQs which must be about 100% here to show in blue.

A gradient would add another config option and make things even more complicated.

A link in this context is one available connection. Two nodes which are connected through 2.4 GHz and wired have multiple links of different type then (see example here: https://map.aachen.freifunk.net/#/en/map/f4f26d4a22c4-60e327cf35a)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants